Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove duplicated script create-single-vm-mcis.sh #1058

Merged
merged 1 commit into from
Apr 8, 2022
Merged

Remove duplicated script create-single-vm-mcis.sh #1058

merged 1 commit into from
Apr 8, 2022

Conversation

seokho-son
Copy link
Member

fix #1037

@seokho-son seokho-son requested a review from jihoon-seo as a code owner April 7, 2022 05:44
@seokho-son
Copy link
Member Author

@jihoon-seo 참고,

CB-TB 에는 https://github.com/cloud-barista/cb-tumblebug/blob/main/CODEOWNERS 를 사용하고 있고,

prow-for-cloud-barista 은 OWNERS 를 확인하려고 하네요.

https://github.com/cloud-barista/cb-tumblebug/blob/main/OWNERS
이거 아마도 자체 스타일의 코드오너 파일을 사용하는 거라, github-native한 CODEOWNERS 랑 조금 다르게 생겼을거예요.
https://github.com/kubernetes/website/blob/main/OWNERS

@jihoon-seo jihoon-seo added lgtm This PR is acceptable by at least one reviewer approved This PR is approved and will be merged soon. labels Apr 8, 2022
@prow-for-cloud-barista
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

Approval requirements bypassed by manually added approval.

This pull-request has been approved by: seokho-son

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

1 similar comment
@prow-for-cloud-barista
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

Approval requirements bypassed by manually added approval.

This pull-request has been approved by: seokho-son

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jihoon-seo jihoon-seo merged commit 034a5b0 into cloud-barista:main Apr 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jihoon-seo jihoon-seo Awaiting requested review from jihoon-seo

Assignees
No one assigned
Labels
approved This PR is approved and will be merged soon. lgtm This PR is acceptable by at least one reviewer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Delete dup test script: create-single-vm-mcis.sh
2 participants
@seokho-son @jihoon-seo